DM-34315: Move rapid_analysis code to summit_utils and summit_extras#2
Merged
mfisherlevine merged 4 commits intomainfrom Apr 23, 2022
Merged
DM-34315: Move rapid_analysis code to summit_utils and summit_extras#2mfisherlevine merged 4 commits intomainfrom
mfisherlevine merged 4 commits intomainfrom
Conversation
Code was transferred from rapid_analysis: https://github.com/lsst-sitcom/rapid_analysis/ Transfer branch is tickets/DM-34315-transfer
isullivan
approved these changes
Apr 22, 2022
isullivan
left a comment
isullivan
left a comment
There was a problem hiding this comment.
Several files have imports such as from lsst.summit.extras.headerFunctions import ..., which could be relative imports.
Contributor
Author
Ooooh, yes, fair comment. There's history there, which is why, and I'll make a mental note to fix that in the future, but with all the churn right now, and the poor test coverage in places (ticketed to fix) I'd rather save any changes like that for when things are a little more stable/tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.