Conversation
ktlim
force-pushed
the
tickets/DM-44304
branch
2 times, most recently
from
0bf59cb to
5c33e81
Compare
| self.url = os.environ["LSST_CONSDB_PQ_URL"] | ||
| else: | ||
| self.url = url | ||
| self.url = self.url.rstrip("/") |
Contributor
There was a problem hiding this comment.
Given that LSST_CONSDB_PQ_URL could not be set at all, maybe a check inside the init to ensure we didn't end up with nothing, only to fail later on use? Oh, except you're using os.environ rather than getenv(), so I guess that throws a KeyError actually, which is going to be less user-friendly, but certainly does the trick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.