DM-46784: Add function for getting ecliptic coordinates#127
Merged
mfisherlevine merged 2 commits intomainfrom Nov 26, 2024
Merged
DM-46784: Add function for getting ecliptic coordinates#127mfisherlevine merged 2 commits intomainfrom
mfisherlevine merged 2 commits intomainfrom
Conversation
mfisherlevine
force-pushed
the
tickets/DM-46784
branch
from
9681d66 to
decf9a2
Compare
TallJimbo
approved these changes
Nov 11, 2024
Contributor
TallJimbo
left a comment
TallJimbo
left a comment
There was a problem hiding this comment.
I know you probably can't do it now, but if you're reimplementing something from astropy for performance reasons, it's both particularly important and particularly easy to add a unit test.
mfisherlevine
force-pushed
the
tickets/DM-46784
branch
from
decf9a2 to
e5823e4
Compare
Contributor
Author
Good shout - done 🙂 |
mfisherlevine
force-pushed
the
tickets/DM-46784
branch
from
4722595 to
e964724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.