DM-52818: Allow specifying database name in makeEfdClient#165
Merged
mfisherlevine merged 1 commit intomainfrom Oct 8, 2025
Merged
DM-52818: Allow specifying database name in makeEfdClient#165mfisherlevine merged 1 commit intomainfrom
mfisherlevine merged 1 commit intomainfrom
Conversation
RobertLuptonTheGood
approved these changes
Oct 8, 2025
Member
RobertLuptonTheGood
left a comment
RobertLuptonTheGood
left a comment
There was a problem hiding this comment.
Looks good. Thanks
| raise RuntimeError("Could not create EFD client because importing lsst_efd_client failed.") | ||
|
|
||
| if testing: | ||
| return EfdClient("usdf_efd") |
Member
There was a problem hiding this comment.
I might have defined a dict with new args (just db_name for now), so that if you ever add another arg to pass through you won't have to modify all these lines again
mfisherlevine
force-pushed
the
tickets/DM-52818
branch
from
cfb8a24 to
43e3364
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.