DM-37252: Move util from RubinTV to summit_utils#28
Merged
mfisherlevine merged 2 commits intomainfrom Dec 7, 2022
Merged
Conversation
isullivan
approved these changes
Dec 6, 2022
Contributor
isullivan
left a comment
isullivan
left a comment
There was a problem hiding this comment.
Main suggestion is to update __all__
| The exposure. | ||
| """ | ||
| if not logger: | ||
| logger = logging.getLogger(__name__) |
Contributor
There was a problem hiding this comment.
Maybe I just don't know this code well enough, but where is __name__ coming from?
Contributor
Author
There was a problem hiding this comment.
I'm pretty sure that's always defined. Like, just open a python terminal and type print(__name__) and it should tell you that you're in __main__.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.