You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@mfisherlevine I'm not entirely sure how you want to play this. Do you have users of your utility datasetExists function outside of this package? Are you going to be running this code with an old butler that doesn't have .exists()? The comment associated with the utility function indicated you were happy to remove the function when the new API exists.
As discussed OOB, I'm not too worried about users, but there's one instance in summit_extras and two in rubintv_production, both of which I'm happy to fix up later, but adding a deprecation warning for now, so that stacks can be updated with the coming weekly and then make use of it, would be a much easier path to getting this removed. But yes, to the "should it be removed", very much so, the intent was indeed always to get rid of that (and in fact as much else in this file as possible tbh!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires lsst/daf_butler#840