DM-40512: fix bitrot in QuickLookIsrConnections#76
Merged
Conversation
This is now automatic when setattr is called.
TallJimbo
force-pushed
the
tickets/DM-40512
branch
from
f612892 to
bbfad32
Compare
mfisherlevine
approved these changes
Dec 11, 2023
Contributor
mfisherlevine
left a comment
mfisherlevine
left a comment
There was a problem hiding this comment.
Thanks Jim - looks great, works great! Only thing I'm confused by is why the GitHub button is green when it needs rebasing (you got sniped by Eli). Surely it doesn't do that automatically now, does it? Do I need to enable something else GitHub to make it flag that?
Contributor
Author
|
It's just that I had already rebased by the time you finished your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.