DM-54675: Add higher-order moments to ExposureSummaryStats#828
Merged
Conversation
laurenam
force-pushed
the
tickets/DM-54675
branch
3 times, most recently
from
92f0ffa to
2d794a6
Compare
arunkannawadi
approved these changes
Apr 22, 2026
| schema.addField( | ||
| "starTrefoil1Median", | ||
| type="F", | ||
| doc="Trefoil-like higher-order moment combination: medain M30 - 3*M12 " |
Member
There was a problem hiding this comment.
Suggested change
| doc="Trefoil-like higher-order moment combination: medain M30 - 3*M12 " | |
| doc="Trefoil-like higher-order moment combination: median M30 - 3*M12 " |
| """ | ||
|
|
||
| starTrefoil1Median: float = float('nan') | ||
| """Trefoil-like higher-order moment combination: medain M30 - 3*M12 |
Member
There was a problem hiding this comment.
Suggested change
| """Trefoil-like higher-order moment combination: medain M30 - 3*M12 | |
| """Trefoil-like higher-order moment combination: median M30 - 3*M12 |
| """ | ||
|
|
||
| starTrefoil2Median: float = float('nan') | ||
| """Trefoil-like higher-order moment combination: medain 3*M21 - M03 |
Member
There was a problem hiding this comment.
Suggested change
| """Trefoil-like higher-order moment combination: medain 3*M21 - M03 | |
| """Trefoil-like higher-order moment combination: median 3*M21 - M03 |
| starE42Median: float = float('nan') | ||
| """Fourth-order ellipticity-like higher-order moment combination, 2*(M31 + M13) | ||
| of the stars used in the PSF model. | ||
| """ |
Member
There was a problem hiding this comment.
Curious why we don't include median in the docs for these two
Contributor
Author
There was a problem hiding this comment.
Heh...just oversight. Thanks for the catch!
| schema.addField( | ||
| "starTrefoil2Median", | ||
| type="F", | ||
| doc="Trefoil-like higher-order moment combination: medain 3*M21 - M03 " |
Member
There was a problem hiding this comment.
Suggested change
| doc="Trefoil-like higher-order moment combination: medain 3*M21 - M03 " | |
| doc="Trefoil-like higher-order moment combination: median 3*M21 - M03 " |
laurenam
force-pushed
the
tickets/DM-54675
branch
from
2d794a6 to
ee4c0ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.