DM-35683: Remove references to columns (colKey and columnKey) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bechtol
reviewed
Jul 21, 2022
| self.scalarActions.median = MedianAction(colKey=self.columnKey) | ||
| self.scalarActions.sigmaMad = SigmaMadAction(colKey=self.columnKey) | ||
| self.scalarActions.count = CountAction(colKey=self.columnKey) | ||
| self.scalarActions.median = MedianAction(veectorKey=self.vectorKey) |
Contributor
There was a problem hiding this comment.
Notice typo veectorKey. A few instances in this file.
bechtol
reviewed
Jul 21, 2022
|
|
||
| class MedianAction(ScalarAction): | ||
| colKey = Field[str]("Key of Vector to median") | ||
| veectorKey = Field[str]("Key of Vector to median") |
Contributor
There was a problem hiding this comment.
Notice typo veectorKey. A few instances in this file.
bechtol
reviewed
Jul 21, 2022
| self.process.calculateActions.meanSky = MeanAction(colKey=f"{{band}}_{self.fluxType}") | ||
| self.process.calculateActions.stdevSky = StdevAction(colKey=f"{{band}}_{self.fluxType}") | ||
| self.process.calculateActions.sigmaMADSky = SigmaMadAction(colKey=f"{{band}}_{self.fluxType}") | ||
| self.process.calculateActions.medianSky = MedianAction(veectorKey=f"{{band}}_{self.fluxType}") |
Contributor
There was a problem hiding this comment.
veectorKey several instances
bechtol
reviewed
Jul 21, 2022
| self.scalarActions.median = MedianAction(colKey=self.columnKey) # type: ignore | ||
| self.scalarActions.sigmaMad = SigmaMadAction(colKey=self.columnKey) # type: ignore | ||
| self.scalarActions.count = CountAction(colKey=self.columnKey) # type: ignore | ||
| self.scalarActions.median = MedianAction(veectorKey=self.vectorKey) # type: ignore |
Contributor
There was a problem hiding this comment.
veectorKey several instances
bechtol
reviewed
Jul 21, 2022
| multiple = ConfigurableActionStructField[ScalarAction](doc="Multiple Actions") | ||
|
|
||
| def getInputSchema(self) -> KeyedDataSchema: | ||
| return (("a", Vector),) |
Contributor
There was a problem hiding this comment.
veectorKey several instances
bechtol
approved these changes
Jul 21, 2022
Contributor
bechtol
left a comment
bechtol
left a comment
There was a problem hiding this comment.
I have searches all the files for any instances of columnKey and colKey and do not find any instances.
There are multiple files that have veectorKey typo. Looks good once the typo is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.