dm 35622: Implement tests for scalar and vector actions #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Jul 29, 2022
| "g_iixy": r * r[::-1], | ||
| } | ||
|
|
||
| self.data = pd.DataFrame.from_dict(data) |
Contributor
There was a problem hiding this comment.
Why did you turn this into a DataFrame? This should be fine as is as a dictionary...
Contributor
Author
There was a problem hiding this comment.
I just wanted to test with a DataFrame. Before I did, there was at least one test that worked with a Dict but not a DataFrame, so it seemed worth including.
fred3m
force-pushed
the
tickets/DM-35622
branch
from
4107fc7 to
1a99d45
Compare
fred3m
force-pushed
the
tickets/DM-35622
branch
from
1a99d45 to
5c708e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.