DM-51670: Change to use object_parent #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
force-pushed
the
tickets/DM-51670
branch
4 times, most recently
from
bb759e4 to
cde41c7
Compare
TallJimbo
reviewed
Nov 26, 2025
Member
TallJimbo
left a comment
TallJimbo
left a comment
There was a problem hiding this comment.
There's a lot of black magic here I'm not familiar with; I'd be more comfortable if you could find another more expert reviewer for this package.
sr525
reviewed
Nov 26, 2025
| "detect_isDeblendedModelSource", | ||
| "sky_object", | ||
| ] | ||
| self.selectWhenTrue = ["detect_isPatchInner"] |
Collaborator
There was a problem hiding this comment.
Should there be any changes to coaddObjectSelector?
Contributor
Author
There was a problem hiding this comment.
The CoaddPlotFlagSelector? No, I don't think so. I know that you kind of came in the middle of the review without seeing the upstream changes but those columns still exist in the object table, just not the new object_parent table that is only used for the deblender metrics.
sr525
approved these changes
Nov 26, 2025
fred3m
force-pushed
the
tickets/DM-51670
branch
2 times, most recently
from
2f23b80 to
66f4505
Compare
fred3m
force-pushed
the
tickets/DM-51670
branch
from
66f4505 to
e443f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.