DM-53369: Add post-subtracted background stats to calibrateImage metadata metrics #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
approved these changes
Nov 26, 2025
Contributor
mrawls
left a comment
mrawls
left a comment
There was a problem hiding this comment.
Let's play names!
I'm noticing the other metrics all end in, e.g., count or fraction, whereas median and stdev are in the middle of the new metric names. Good/bad/desirable...?
I'm also pretty sure the "skyFlux" ones refer to sky sources, and "bg" refers to background, is there a reason not to write this out explicitly? And finally, post_subtraction to me smacks of difference imaging which is of course not the part of the pipeline we are in here.
But the units look correct 😇
Contributor
Author
|
Cool. New name suggestions: |
jrmullaney
force-pushed
the
tickets/DM-53369
branch
from
359e9ef to
ab076e9
Compare
fred3m
force-pushed
the
tickets/DM-53369
branch
from
ab076e9 to
f19c936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.