DM-54136: Create an analysis tool that compares nPeaks to nObjects#470
Merged
jrmullaney merged 2 commits intomainfrom Feb 21, 2026
Merged
DM-54136: Create an analysis tool that compares nPeaks to nObjects#470jrmullaney merged 2 commits intomainfrom
jrmullaney merged 2 commits intomainfrom
Conversation
jrmullaney
force-pushed
the
tickets/DM-54136
branch
from
74c2e45 to
cf18cb8
Compare
fred3m
approved these changes
Feb 20, 2026
Contributor
fred3m
left a comment
fred3m
left a comment
There was a problem hiding this comment.
LGTM, just one minor comment about the implementation.
|
|
||
|
|
||
| class ParentObjectSelector(FlagSelector): | ||
| class ParentObjectSelector(VectorAction): |
Contributor
There was a problem hiding this comment.
I actually wonder if this could still work as a FlagSelector with
self.selectWhenFalse = [
"sky_object",
"parentObjectId"
]
It's a little bit of a hack but it would work because I think that when parentObjectId is zero that should register as False.
Contributor
Author
There was a problem hiding this comment.
Ok - I'll give it a shot and see if it works. It'll be much neater if it does.
Thanks!
jrmullaney
force-pushed
the
tickets/DM-54136
branch
from
cf18cb8 to
6800eff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.