DM-53346: Populate scheduler fields in alert packet #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmartradio
reviewed
Nov 19, 2025
bsmartradio
approved these changes
Nov 19, 2025
Contributor
bsmartradio
left a comment
bsmartradio
left a comment
There was a problem hiding this comment.
The changes look good, though I added a comment for the unit tests. We may want an additional check just to make sure that the target name or observation reason is as expected.
ebellm
force-pushed
the
tickets/DM-53346
branch
from
396b69f to
2f641a2
Compare
ebellm
force-pushed
the
tickets/DM-53346
branch
from
2f641a2 to
f8878ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.