DM-23034: Update cbp for changes in how Cameras and Detectors are built #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
force-pushed
the
tickets/DM-23034
branch
from
9571d23 to
47af3b5
Compare
r-owen
approved these changes
Mar 9, 2020
Contributor
r-owen
left a comment
r-owen
left a comment
There was a problem hiding this comment.
Looks good other than the test error you noted. I made this pull request which I would like you to consider merging to this pull request before merging to master. #8
The changes are:
Clarify some docs (especially now that detectors are sorted by name)
Fix the unit test
Update the way struct attributes are documented to match what I'm doing in all my other packages (since I don't want to document class variables and overwrite them with instance variables, which is one way of getting Sphinx to see them; I consider that confusing and dangerous)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.