DM-53492: Make ctrl_bps work with NetworkX 3.6 #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from ver. 3.6 of NetworkX, the DiGraph class defines its custom __new__ method that explicitly defines arguments it accepts. As a result, we need to override it to let our subclass use different ones.
Removed version restrictions from project files.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 90.31% 90.31%
=======================================
Files 51 51
Lines 5543 5545 +2
Branches 540 540
=======================================
+ Hits 5006 5008 +2
Misses 438 438
Partials 99 99 ☔ View full report in Codecov by Sentry. |
MichelleGower
approved these changes
Jan 9, 2026
Collaborator
MichelleGower
left a comment
MichelleGower
left a comment
There was a problem hiding this comment.
Looks good. Merge approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes