DM-54079: Fix RequestMemory expression where sometimes exceeds the memoryLimit#85
Merged
DM-54079: Fix RequestMemory expression where sometimes exceeds the memoryLimit#85
Conversation
The ClassAd expression responsible for manging memory requests between job's restarts could ignore the imposed memory limits under certain conditions (job is restarted due to reasons other the OOM errors). Fixed that.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 83.90% 83.90%
=======================================
Files 19 19
Lines 4113 4113
Branches 450 450
=======================================
Hits 3451 3451
Misses 585 585
Partials 77 77 ☔ View full report in Codecov by Sentry. |
MichelleGower
approved these changes
Mar 3, 2026
Contributor
MichelleGower
left a comment
There was a problem hiding this comment.
A typo. Code changes look good. Merge approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes