Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 35.68% 35.44% -0.25%
==========================================
Files 14 14
Lines 723 759 +36
Branches 71 80 +9
==========================================
+ Hits 258 269 +11
- Misses 456 475 +19
- Partials 9 15 +6 ☔ View full report in Codecov by Sentry. |
MichelleGower
left a comment
MichelleGower
left a comment
There was a problem hiding this comment.
Ideally there would be a way to make settings per queue. If need this capability ASAP, should punt that to future ticket. Also, I'm not sure whether this would break if the peak settings don't appear in the site config which would be the case for any other sites using this. It would be nice to have defaults so that it doesn't just break. It would be nice to have documentation with the package some day (instead of only in the developer guide) as well as doc/changes.
| action="store", | ||
| default=4096, | ||
| dest="mempercore", | ||
| help="Memory per core to be scheduled by default", |
There was a problem hiding this comment.
Put the units in the help message?
|
|
||
| def getPeakcpus(self): | ||
| """Accessor for PEAKCPUS | ||
| @return the value of PEAKCPUS |
There was a problem hiding this comment.
LSST Developer Guide describes the format for docstrings (mostly Numpydoc style)
| @return the value of PEAKMEMORY | ||
| """ | ||
| peakmemory = self.getParameter("PEAKMEMORY") | ||
| if self.opts.queue == "torino": |
There was a problem hiding this comment.
This conversion seems like it should be in the platform specific package instead of the generic allocator package. Is there a config way to have peak information per queue?
| if self.opts.mempercore: | ||
| self.commandLineDefaults["MEMPERCORE"] = self.opts.mempercore | ||
| else: | ||
| self.commandLineDefaults["MEMPERCORE"] = 4096 |
There was a problem hiding this comment.
Would be nice to not replicate this value here and in the default value for the command line options.
| """Accessor for PEAKMEMORY | ||
| @return the value of PEAKMEMORY | ||
| """ | ||
| peakmemory = self.getParameter("PEAKMEMORY") |
There was a problem hiding this comment.
Does getParameter guarantee a value (the default in the pex config is None)
2 participants
No description provided.