DM-52801: Require minimum number of detectors per visit #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Oct 22, 2025
| observatories.append(observatory_icrs.cartesian.xyz.to(u.AU).value) | ||
|
|
||
| validDetectors = [row for row in visitSummary if row.wcs is not None] | ||
| if len(validDetectors) < self.config.minDetectors: |
Contributor
There was a problem hiding this comment.
Could this be a fraction of the total number of detectors, rather than a fixed minimum number? I think that would translate better to other cameras (especially ComCam!).
Collaborator
Author
There was a problem hiding this comment.
That's a good idea. I just realized that I would need a comCam override for the config option as written, but it would be simpler to change this to a fraction that will work for everything.
|
|
||
| validDetectors = [row for row in visitSummary if row.wcs is not None] | ||
| if len(validDetectors) < self.config.minDetectors: | ||
| continue |
Contributor
There was a problem hiding this comment.
Should there be an INFO or WARN level log message when skipping a visit?
cmsaunders
force-pushed
the
tickets/DM-52801
branch
from
8184fb1 to
26322dd
Compare
cmsaunders
force-pushed
the
tickets/DM-52801
branch
from
26322dd to
2b977f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.