Skip to content

DM-52801: Require minimum number of detectors per visit #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

DM-52801: Require minimum number of detectors per visit #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions python/lsst/drp/tasks/gbdesAstrometricFit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,14 @@ class GbdesAstrometricFitConfig(
optional=True,
default=None,
)
minDetectorFraction = pexConfig.Field(
dtype=float,
doc=(
"Minimum fraction of detectors with valid WCSs per visit required to include the visit in the "
"fit."
),
default=0.25,
)

def setDefaults(self):
# Use only stars because aperture fluxes of galaxies are biased and
Expand Down Expand Up @@ -1138,6 +1146,17 @@ def _get_exposure_info(
# We want the position in AU in Cartesian coordinates
observatories.append(observatory_icrs.cartesian.xyz.to(u.AU).value)

validDetectors = [row for row in visitSummary if row.wcs is not None]
nDetectorFraction = len(validDetectors) / len(visitSummary)
if nDetectorFraction < self.config.minDetectorFraction:
self.log.warning(
"Visit %d has only %d detectors with valid WCSs (%s of total) and will be dropped.",
visit,
len(validDetectors),
nDetectorFraction,
)
continue
Copy link
Contributor

@isullivan isullivan Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be an INFO or WARN level log message when skipping a visit?


for row in visitSummary:
detector = row["id"]

Expand Down