DM-50108: Update artifact rejection configs for DP2 #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed if we want detection to do any backgrounds subtraction during detection
yalsayyad
force-pushed
the
tickets/DM-50108
branch
from
784b0f3 to
da595a3
Compare
isullivan
approved these changes
Dec 3, 2025
Contributor
isullivan
left a comment
isullivan
left a comment
There was a problem hiding this comment.
Looks good, though make sure to fix the linting error.
Comment on lines
+1473
to
+1474
| self.detectTemplate.doTempLocalBackground = True | ||
| self.detectTemplate.reEstimateBackground = True |
Contributor
There was a problem hiding this comment.
It is not for this ticket, but we could replace the background subtraction built in to the detection task with the version I wrote for subtractImages that allows for outlier rejection and does a better job around artifacts and bright stars.
| self.detect.returnOriginalFootprints = False | ||
| self.detect.thresholdPolarity = "both" | ||
| self.detect.thresholdValue = 5 | ||
| self.detect.thresholdValue = 6 |
Contributor
There was a problem hiding this comment.
I thought your examples with thresholdValue = 7.5 looked convincing, but no objection to 6.
Contributor
Author
There was a problem hiding this comment.
oooo, thank you for sharing that thought :)
yalsayyad
force-pushed
the
tickets/DM-50108
branch
3 times, most recently
from
f590c07 to
8b90992
Compare
by shrinking safe zones by: - increasing detection threshold - adjusting background estimation configs in detection of safe zones - and using calcErrorFromInputVariance in computation of template variance.
yalsayyad
force-pushed
the
tickets/DM-50108
branch
from
8b90992 to
f5dd20f
Compare
yalsayyad
force-pushed
the
tickets/DM-50108
branch
from
f5dd20f to
1d4457d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.