DM-54418: Update stellar motions covariance output#219
Merged
cmsaunders merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
cmsaunders
force-pushed
the
tickets/DM-54418
branch
from
61284f4 to
4bbadcd
Compare
fred3m
approved these changes
Apr 13, 2026
Contributor
fred3m
left a comment
fred3m
left a comment
There was a problem hiding this comment.
Everything that you've done looks good but I wonder if it would be useful to include a helper function to extract the appropriate columns from the catalog to rebuild the covariance matrix. I'll leave it up to your discretion whether or not that would be worth implementing. If so, then you probably want to make a constant that contains the positionNames in case they ever change. In fact, you might want to do that anyway instead of having them hard coded inside of the method.
cmsaunders
force-pushed
the
tickets/DM-54418
branch
from
4bbadcd to
68792ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.