DM-53026: Add option to use isolated stars as input#223
Merged
Conversation
cmsaunders
force-pushed
the
tickets/DM-53026
branch
2 times, most recently
from
cf209c1 to
2f69c32
Compare
kherner
approved these changes
May 12, 2026
kherner
left a comment
kherner
left a comment
There was a problem hiding this comment.
I think everything is OK, but I had a couple of minor conceptual questions and one thing to double check whether you need an if-else or not.
These are gated by the new useIsolatedStars config parameter. This task also moves methods from the "global" version into the base class and streamlines the isolated star loading and format conversion.
cmsaunders
force-pushed
the
tickets/DM-53026
branch
from
2f69c32 to
675b420
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.