DM-54856: Add support for resolving referenced schemas automatically and convert the CLI to use resource paths and URIs#181
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 91.78% 91.81% +0.03%
==========================================
Files 13 13
Lines 2046 2066 +20
Branches 296 300 +4
==========================================
+ Hits 1878 1897 +19
Misses 110 110
- Partials 58 59 +1 ☔ View full report in Codecov by Sentry. |
JeremyMcCormick
force-pushed
the
tickets/DM-54856
branch
4 times, most recently
from
6093a24 to
e74e4f7
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-54856
branch
from
e74e4f7 to
2f0ce18
Compare
JeremyMcCormick
commented
May 14, 2026
JeremyMcCormick
force-pushed
the
tickets/DM-54856
branch
from
6b4da87 to
ee97c1f
Compare
timj
approved these changes
May 14, 2026
Member
timj
left a comment
timj
left a comment
There was a problem hiding this comment.
Looks okay. Still not sure why you didn't change the file to uri and keep the same helper.
JeremyMcCormick
force-pushed
the
tickets/DM-54856
branch
from
d350db8 to
d9e906a
Compare
Collaborator
Author
Please see #181 (comment). |
timj
reviewed
May 14, 2026
This changes all logging calls to use printf rather than than f-string formatting.
There are issues manging the logger when `felis` is used as the logger name. This changes several loggers to use their full module names instead.
JeremyMcCormick
force-pushed
the
tickets/DM-54856
branch
from
efeb805 to
abf1322
Compare
This adds explicit handler config to the `cli` module and sets the default log level to `DEBUG` when running tests. Log messages will still be filtered based on the `--log-cli-level` of `pytest`, which is the desired behavior.
pydocstyle seems to be confusing this with the `Parameters` section from the docstring.
JeremyMcCormick
force-pushed
the
tickets/DM-54856
branch
from
abf1322 to
71a2682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the resolution of relative resource URIs such as
uri: drp_base.yamlto use the schema's base path. For instance, if the schema was loaded fromfile:///tmp/yml/schema.yaml, then for a resource this would resolve tofile:///tmp/tmp/drp_base.yaml. Referenced URIs with absolute paths will not trigger this behavior.The command line interface was also converted to use URIs, because the previous behavior using file streams did not provide URIs for this resolution.
Checklist
docs/changes