DM-53369: Add post-subtracted background stats to calibrateImage metadata metrics #1196
Conversation
jrmullaney
force-pushed
the
tickets/DM-53369
branch
2 times, most recently
from
e1164ce to
de897f6
Compare
mrawls
left a comment
mrawls
left a comment
There was a problem hiding this comment.
Looks good. It appears everything you've added is very lightweight and shouldn't affect the runtime - please shout if you DON'T think that is the case (this matters a lot for AP).
| self._summarize(result.exposure, summary_stat_catalog, result.background) | ||
|
|
||
| # Output post-subtraction background stats to task metadata: | ||
| bgIgnoreMaskPlanes = [ |
There was a problem hiding this comment.
Please add a comment describing what "ignore" means here - pixels with any of these masks are excluded from the background-related statistics metric calculations. I get worried when I see "badMaskPlanes" or "ignoreMaskPlanes" out of the blue without an explicit reassurance this is just for metrics.
Also, consider making this configurable vs hard wired, in the event we want to (I don't know) add STREAK to it some day...
There was a problem hiding this comment.
Isn't the new SPIKE mask also available now, via calibrateImage? Should it be in the list?
There was a problem hiding this comment.
Thanks for hopping on this so quickly. 👍 to adding the comment and config. Not sure about SPIKE. I did have that, but then it broke pipe_task tests in Jenkins. I've no idea why, cos it should exist.
jrmullaney
force-pushed
the
tickets/DM-53369
branch
3 times, most recently
from
c5359f5 to
f665dd1
Compare
fred3m
force-pushed
the
tickets/DM-53369
branch
from
f665dd1 to
c4efd78
Compare
No description provided.