DM-53304: Pass attribute result struct into _compute_psf #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
force-pushed
the
tickets/DM-53304
branch
7 times, most recently
from
339bee5 to
ae81664
Compare
leeskelvin
force-pushed
the
tickets/DM-53304
branch
from
ae81664 to
c4ae440
Compare
jrmullaney
approved these changes
Dec 3, 2025
Contributor
jrmullaney
left a comment
jrmullaney
left a comment
There was a problem hiding this comment.
LGTM!
Just one comment that you may want to address if you're feeling picky! Up to you.
tests/test_calibrateImage.py
Outdated
| self.exposure.metadata["LSST ISR FLAT APPLIED"] = True | ||
|
|
||
| # Set up a basic results struct to hold exposure attribute data | ||
| self.results = pipeBase.Struct() |
Contributor
There was a problem hiding this comment.
This is probably my fault. Can you be bothered to do self.results -> self.result to be consistent with what's in calibrateImage.py?
But LGTM!
Contributor
Author
There was a problem hiding this comment.
Happy to. I considered naming this something else more descriptive here, like attribs or attributes, as result only really makes sense in the context of CalibrateImageTask. Any preferences for consistency over descriptiveness?
Contributor
Author
There was a problem hiding this comment.
Plumped for self.attributes, as result is being used in other contexts in the script already.
leeskelvin
force-pushed
the
tickets/DM-53304
branch
from
c4ae440 to
23c855d
Compare
Here we pass the full results attributes struct into _compute_psf. This allows us to persist the background in the event that a failure arises during processing. At present, we might persist a background-subtracted exposure but not the associated background if an error occurs mid-processing.
leeskelvin
force-pushed
the
tickets/DM-53304
branch
from
23c855d to
a98e4ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.