DM-54235: Fix transform of moments to sky coordinates in functors#1265
Merged
DM-54235: Fix transform of moments to sky coordinates in functors#1265
Conversation
ctslater
force-pushed
the
tickets/DM-54235
branch
from
15970f5 to
e2e61b3
Compare
arunkannawadi
approved these changes
Feb 23, 2026
tests/test_functors.py
Outdated
| self.assertFloatsAlmostEqual(output_axes_theta_corr, np.array(axes_theta), rtol=1e-7) | ||
|
|
||
| # TODO: These tolerances are looser than we would like, would be better to | ||
| # rely on afwGeom for conversions: DM-54015 |
Member
There was a problem hiding this comment.
Is it time to remove this comment?
PFLeget
approved these changes
Feb 24, 2026
ctslater
force-pushed
the
tickets/DM-54235
branch
from
e2e61b3 to
20328e7
Compare
Also tighten up the test tolerances since they agree better with the geom calculation.
ctslater
force-pushed
the
tickets/DM-54235
branch
from
20328e7 to
531d1b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also tighten up the test tolerances since they agree better with the geom calculation.