tickets/SP-3022: option to map colors to observation_reason in plot_visit_param_vs_time#202
Merged
Conversation
rhiannonlynne
approved these changes
May 11, 2026
Member
rhiannonlynne
left a comment
rhiannonlynne
left a comment
There was a problem hiding this comment.
It looks like all of the observation reasons available across all of the range of simulations ends up in the list at the bottom? The only drawback here is that it makes it a bit complicated to figure out what changed in different realizations of the different simulations.
Still - I think this is more useful in seeing how FBS choices changed than the color-coding per filter, so let's try it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial draft of the code was done with AI (claude code), and then edited to fix it.