Skip to content

Conversation

@isullivan
Copy link
Contributor

Checklist

When making changes to YAML files in the schemas directory:

@JeremyMcCormick
Copy link
Collaborator

@isullivan Please do not add back the @id fields. They should not be needed going forward.

Default schema for outputs of the LSSTCam Data Release Production Pipeline.
'@id': '#lsstcamSchema'
description: 'Default schema for outputs of the LSSTCam Data Release Production Pipeline.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these extra spaces in the description.

of variable and slowly-moving objects) detected and measured on coadds."
description: Descriptions of static astronomical objects (or the static aspects
of variable and slowly-moving objects) detected and measured on coadds.
'@id': '#Object'
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all @id field additions - they are not needed can be generated automatically (see dp1).

@isullivan isullivan force-pushed the tickets/DM-53254 branch 4 times, most recently from 64f0fa9 to d874984 Compare December 3, 2025 20:03
ivoa:ucd: stat.stdev
- name: u_psfFluxNdata
datatype: int
nullable: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the current data in production APDB I see that many records have *_psfFluxNdata fields as NULL. I guess pipelines currently do not set it to 0 when there are no detections in a corresponding band?
Also note that Cassandra does not support NOT NULL columns, but this could be a problem for SQL backend.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change came up because we found (in DRP) that these columns were getting set with NaNs and turned into floats. My code will now set any non-nullable columns with values of NaN to 0 instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we will also need to update existing data to replace NULLs with 0 in those columns? This should be ~trivial for SQL, but not so much for Cassandra. Version number at the top of the file needs to be incremented, please update it to "9.1.1".

Copy link
Member

@ctslater ctslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the DRP side, if it's also ok for APDB. I could see leaving mpc_orbits unchanged if you want; since we're not generating that table, nulls aren't going to cause the same problems (and I don't know if their data might have nulls encoded in some way).

@isullivan
Copy link
Contributor Author

Looks good from the DRP side, if it's also ok for APDB. I could see leaving mpc_orbits unchanged if you want; since we're not generating that table, nulls aren't going to cause the same problems (and I don't know if their data might have nulls encoded in some way).

Good point, I'll drop the mpc_orbits changes.

@isullivan isullivan merged commit e56952c into main Dec 4, 2025
13 of 15 checks passed
@isullivan isullivan deleted the tickets/DM-53254 branch December 4, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants