DM-54765: Enhance showVisitSkyMap with additional functionality#79
Merged
Conversation
leeskelvin
force-pushed
the
tickets/DM-54765
branch
from
23ec73d to
5677664
Compare
leeskelvin
force-pushed
the
tickets/DM-54765
branch
from
5677664 to
96bf183
Compare
leeskelvin
changed the title
The current `--trimToTracts` argument leads the user to suspect that the plot limits will be trimmed to the tracts identified by the user when using `--tracts`. In fact, `--trimToTracts` trims the plot limits to all tracts which overlap the visit list. On this commit, we redefine `--trimToTracts` to instead correctly trim the plot limits to the tracts that the user specifies via `--tracts`. To maintain the current behavior, a new flag `--trimToOverlappingTracts` is provided which, as the name suggests, trims the plot limits to all tracts which overlap the visit list. These edits allow us to focus on a singular tract, if desired. Note: additional logic on this commit has been added to address CCD ID labels being plotted outside of the plot limits. When focusing on a single tract, this is a normal occurance for an LSSTCam visit.
Moving from dashed to dotted helps minimize confusion with tract boundaries, which are also dashed.
leeskelvin
force-pushed
the
tickets/DM-54765
branch
from
6b3004d to
2ee13c7
Compare
If a user passes in /path/to/my/file without an extension, matplotlib will automatically add a default extension (.png). It can then be confusing when the final log message states that /path/to/my/file has been created, when in fact it is /path/to/my/file.png. This commit grabs the default matplotlib extension and correctly appends it for the purposes of logging if none is provided by the user.
leeskelvin
force-pushed
the
tickets/DM-54765
branch
from
2ee13c7 to
bf7ac18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.