DM-53819: Apply miscellaneous fixes to source_injection #68
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Generate injection IDs (if not provided) and injection flag column. | ||
| injection_data = vstack(injection_catalogs) | ||
| injection_data = vstack(injection_catalogs, metadata_conflicts="silent") |
Member
There was a problem hiding this comment.
I don't know what motivates this change?
Was this raising bunch of unwanted warnings? I am ok with it but it is "silencing" conflicts.
In any case, injection catalogs have metadata at all?
Collaborator
Author
There was a problem hiding this comment.
Yes, it was generating a large number of warnings which were polluting the log. As we don't use the metadata, these can be safely ignored.
Collaborator
Author
|
Built docs can be found here: https://s3df.slac.stanford.edu/people/lskelvin/source_injection/lsst.source.injection/index.html These don't have the style sheet formatting of pipelines.lsst.io, but the content is the same. |
BrunoSanchez
approved these changes
Jan 15, 2026
Astropy can attempt to merge multiple Table objects together, e.g., via vstack. If these astropy tables have conflicting metadata keys then astropy will generate a warning. This warning is not useful and the metadata is not used during any stage of source injection processing. We suppress these warnings here to avoid spamming the output logs.
leeskelvin
force-pushed
the
tickets/DM-53819
branch
from
b05916e to
e6f9631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.