DM-53324: Modify make_injection_pipeline to only reconfigure immediate consumers of the injected dataset type#70
Merged
Merged
Conversation
leeskelvin
force-pushed
the
tickets/DM-53324
branch
from
d0b29d4 to
786f461
Compare
leeskelvin
force-pushed
the
tickets/DM-53324
branch
from
786f461 to
db7622a
Compare
This commit rewrites the make_injection_pipeline helper script to output pipelines which adhere to the recommended synthetic dataset naming convention adopted on RFC-1171. Now, only the immediate consuming tasks of a synthetic dataset have their input connections modified to accept an injected input. No further downstream connections are modifeid. This change was made to facilitate the growing use of dynamic connections across the stack, and a reflection of the fact that it currently impossible for us to programattically update a dynamic connection.
leeskelvin
force-pushed
the
tickets/DM-53324
branch
from
db7622a to
36d0569
Compare
BrunoSanchez
approved these changes
May 12, 2026
Member
BrunoSanchez
left a comment
BrunoSanchez
left a comment
There was a problem hiding this comment.
Lee, I see the changes, they look good to me. I agree, this is what RFC-1171 is about.
On AP we will need to start tagging collections with fakes and making sure this is not mixed. That's all. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.