SP-2386: add user-table upload and cross-match 100-level tutorial #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MelissaGraham
changed the title
MelissaGraham
approved these changes
Sep 22, 2025
Contributor
MelissaGraham
left a comment
MelissaGraham
left a comment
There was a problem hiding this comment.
Big thing:
- rename file to be "102_6_Cross_match_to_uploaded_table.ipynb", there's already a 102_5
Minor things:
- header, change "DP1" to a hotlink "Data Preview 1"
- subsections, convention is to have a period after the number, "1.1. Import packages" and so on, to match
- Section 3 header doesn't need "from external TAP query" (removing will make it consistent with the Section 2 header)
- Section 3.2, recommend to move the commented-out line
# gaia_resultsto its own cell, preceded with a markdown cell saying "Option to view the reformatted table"
I think that should all be pretty easy so I'm going to Approve the PR in advance so you don't need to re-request review.
GloriaFA
force-pushed
the
tickets/SP-2386
branch
from
a76abc8 to
032be5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.