tickets/SP-2540: add photometry evaluation#97
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
sgreenstreet
left a comment
There was a problem hiding this comment.
Couple of comments about the additions to the notebook:
- Figure 3 caption: "The grey line is drawn at 0.25 mag..."; since the line is dashed, it might be slightly clearer to say "The dashed grey line at 0.25 mag..."
- Formatting trouble in the final cell of Section 3.3: rmsmag $> 0.25` mag
Also, re-looking at the Community thread that prompted these notebook additions, there isn't a specific request from the user about how to filter out the photometric outliers but instead there is a focus on the cause of those outliers. From Community (https://community.lsst.org/t/outlier-magnitudes-in-the-solar-system-first-look-mpc-reported-detections/10671): "I was wondering if it’s known what happened with the observations? Bad observing conditions or something going on with the calibration? The photometric quality of this dataset is fantastic, so I’m really asking more out of curiosity because I would take a look at the images if this was in DP1."
These notebook additions address how to see find the outliers from the MPC data, but not the cause of those outliers. Do we want to add more text to the notebook to say that the images aren't available to investigate the cause of the outliers?
Other than that, I think these additions are really useful and should be included.
|
Fixed 1 and 2, and did a whole exploration of the images which I'll describe in the Jira ticket. Merging this PR. |
No description provided.