Skip to content

tickets/SP-2540: add photometry evaluation#97

Merged
MelissaGraham merged 2 commits into
mainfrom
tickets/SP-2540
Nov 26, 2025
Merged

tickets/SP-2540: add photometry evaluation#97
MelissaGraham merged 2 commits into
mainfrom
tickets/SP-2540

Conversation

@MelissaGraham
Copy link
Copy Markdown
Contributor

No description provided.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Copy Markdown
Contributor

@sgreenstreet sgreenstreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments about the additions to the notebook:

  1. Figure 3 caption: "The grey line is drawn at 0.25 mag..."; since the line is dashed, it might be slightly clearer to say "The dashed grey line at 0.25 mag..."
  2. Formatting trouble in the final cell of Section 3.3: rmsmag $> 0.25` mag

Also, re-looking at the Community thread that prompted these notebook additions, there isn't a specific request from the user about how to filter out the photometric outliers but instead there is a focus on the cause of those outliers. From Community (https://community.lsst.org/t/outlier-magnitudes-in-the-solar-system-first-look-mpc-reported-detections/10671): "I was wondering if it’s known what happened with the observations? Bad observing conditions or something going on with the calibration? The photometric quality of this dataset is fantastic, so I’m really asking more out of curiosity because I would take a look at the images if this was in DP1."

These notebook additions address how to see find the outliers from the MPC data, but not the cause of those outliers. Do we want to add more text to the notebook to say that the images aren't available to investigate the cause of the outliers?

Other than that, I think these additions are really useful and should be included.

@MelissaGraham
Copy link
Copy Markdown
Contributor Author

Fixed 1 and 2, and did a whole exploration of the images which I'll describe in the Jira ticket. Merging this PR.

@MelissaGraham MelissaGraham merged commit 189e886 into main Nov 26, 2025
2 checks passed
@MelissaGraham MelissaGraham deleted the tickets/SP-2540 branch November 26, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants