feat(frontend): add wrap-around navigation setting#230
Merged
Conversation
Adds a "Wrap Around During Navigation" checkbox to Slideshow Settings (default off). When off, the slideshow stops at the first and last image of the album or search results. When on, scrolling past either end continues seamlessly in the other direction. resolveOffset now uses positive modulo for both directions (the previous `%` behaviour silently wrapped forward but not backward because of JS negative-modulo semantics). The dedup guards that returned early when a globalIndex was already in the swiper DOM are removed for linear navigation — they were blocking wrap-around past the first lap once every globalIndex had appeared at least once. Shuffle-mode dedup is preserved. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Previous behaviour was asymmetric: forward-from-last silently wrapped because
(idx + 1) % totalreturns 0, but backward-from-first stopped because JS's%returns negative for negative dividends. The new logic uses positive modulo((raw % total) + total) % totalso both directions wrap consistently when the setting is on, and returns null at the bounds when off.The two dedup guards (
existsinaddSlideByIndexandprevExistsinslidePrevTransitionEnd) were also blocking wrap navigation past the first lap — once everyglobalIndexin the album / result set had been loaded into the swiper, subsequent forward/backward steps silently no-op'd. Removed for linear navigation; preserved for shuffle mode (still needed when the random picker exhausts attempts in a small pool — covered byswiper-shuffle.test.js).resolveOffsetreturns null whentotal <= 1in wrap mode (nothing to wrap to).Toggling the checkbox calls
resetAllSlides()so any stale wrap-neighbour slides accumulated under the old setting are cleared.Test plan