fix(ci): Inno Setup launcher exe path#301
Merged
Merged
Conversation
Inno resolves relative Source/OutputDir paths against the .iss file's folder, not the repo root, so the build looked for INSTALL/launcher/windows/dist/photomap.exe and aborted. Pass an absolute SourceExe and an absolute output dir (/O) instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The AppImage build hit a transient 502 fetching appimagetool from GitHub's continuous release. Add --retry/--retry-all-errors to the uv and appimagetool downloads. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #300. The first signed
Deploy Launcherrun surfaced one CI bug:Source/OutputDirpaths against the.issfile's folder, not the repo root, so it looked forINSTALL/launcher/windows/dist/photomap.exeand aborted. Now passes an absoluteSourceExeand an absolute output dir (/O).Azure Trusted Signing of the exe itself already succeeded in that run, so this is the only Windows blocker.
(The macOS failure in the same run was a cert-side issue — a PKCS#12 exported by OpenSSL 3 that Apple's importer can't read; fixed by re-exporting the
.p12with-legacy, no code change.)🤖 Generated with Claude Code