Lupl/maybe drop group key#17
Merged
Merged
Conversation
lu-pl
force-pushed
the
lupl/maybe-drop-group-key
branch
from
0509be9 to
ecbe01f
Compare
The change drops the grouping key from the result dataframe if the grouping key is not defined as a model field. This concerns only top models - here group/agg is used which adds the grouping key as a column by default. If a model does not define the grouping key as a field, keeping the grouping key in the dataframe/row binding is unexpected. Closes #16.
The change adds a simple test for checking that the grouping key gets dropped if it is not defined as a field in the model.
lu-pl
force-pushed
the
lupl/maybe-drop-group-key
branch
from
ecbe01f to
d660da3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.