Skip to content

Parameter must be undefined if no fields. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Parameter must be undefined if no fields. #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cubejs-duckdb-driver/src/DuckDBDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class DuckDBDriver extends BaseDriver implements DriverInterface {

// Determine the database URL based on the provided db_path or token
const dbUrl = dbPath ? dbPath : (token ? `md:?motherduck_token=${token}&custom_user_agent=Cube/${version}` : ':memory:');
const dbOptions = token ? { custom_user_agent: `Cube/${version}` } : {};
const dbOptions = token ? { custom_user_agent: `Cube/${version}` } : undefined;

// Create a new Database instance with the determined URL and custom user agent
const db = new Database(dbUrl, dbOptions);
Expand Down