docs(triage): etc_ccpmblocker #26 - won't fix (protocol limit) + sweep close-out#19
Merged
Merged
Conversation
…p close-out Last entry in the upstream-issue triage sweep. Doc-only PR. ## #26 (won't fix) Upstream symptom: with etc_ccpmblocker enabled in a 300-400 user hub, ~4% of users (mostly passive-mode) could still establish CCPM peer- to-peer. Why won't fix: what the script can do, it already does. The residual 4% is a protocol-level limitation, not a script bug: - The script strips CCPM from BINF SU on connect / inf, removing the "CCPM is available" hint other clients use to decide whether to negotiate. - For op-pair interactions it forges BINFs re-adding CCPM only between the two op-level users (legitimate bypass). - Beyond that: CCPM is peer-to-peer. Once two clients have CCPM- state cached from any prior session, they can retry the direct connection without needing fresh advertising. The hub cannot prevent two cooperating clients from opening a TCP socket between themselves. A 100% block would require intercepting CTM/RCM messages and rewriting peer-known-capabilities - hub-core scope, not plugin scope. The upstream issue reporter even acknowledges "only one hub that allows CCPM is enough". ## Sweep close-out This PR closes the post-import upstream-issue triage sweep. All 19 mapped upstream issues against imported plugins now have a documented disposition in docs/UPSTREAM_TRIAGE.md: - 6 issues fixed with code changes (PRs #13 / #15 / #16 / #17 / #18) - 4 issues already addressed by modernisation or v0.8 (PRs #14 / #17) - 2 issues deferred as feature work (PR #17) - 1 issue won't fix as protocol-level limit (this PR) Five general / unmapped upstream issues (#28 search flood, #34 level gate, #33 schedule restart, #25 spam protection, #24 opchat history) belong to hub-core scope or don't have a single home plugin; not addressed in this sweep. The "Plugins not yet triaged" header is replaced with a roll-up disposition table. Closes upstream luadch/scripts#26.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last entry in the post-import upstream-issue triage sweep. Doc-only PR.
#26 (Won't fix)
Upstream symptom: With `etc_ccpmblocker` enabled in a hub of 300-400 users, the issue reporter could still establish CCPM with ~4% of them (mostly passive-mode) - even when both clients only had this one hub in common.
Why won't fix: What the script can do, it already does. The residual is a protocol-level limitation, not a script bug.
A 100% block would require intercepting CTM/RCM messages and rewriting peer-known-capabilities - hub-core scope, not plugin scope. The issue reporter even acknowledges "only one hub that allows CCPM is enough".
Sweep close-out
This PR closes the post-import upstream-issue triage sweep. All 19 mapped upstream issues against imported plugins now have a documented disposition in `docs/UPSTREAM_TRIAGE.md`:
Roll-up: 6 issues with code fixes, 4 already addressed by modernisation or v0.8, 2 deferred as feature work, 1 won't fix.
Five general / unmapped upstream issues (#28 search flood, #34 level-XX login gate, #33 schedule restart, #25 spam protection, #24 opchat history) belong to hub-core scope or don't have a single home plugin; not addressed in this sweep.
The "Plugins not yet triaged" header is replaced with a roll-up disposition table.
Test plan
Closes upstream luadch/scripts#26.