Add delay between punching and digging node#15931
Merged
cx384 merged 1 commit intoluanti-org:masterfrom Apr 4, 2025
Merged
Conversation
Desour
approved these changes
Apr 3, 2025
Member
Desour
left a comment
There was a problem hiding this comment.
Works. 👍
(Also allows to pick up items without punching the node behind, if you want to reproduce easily.)
(Taking the same time as for dig_instantly makes sense.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no delay between punching an entity and starting to dig a node. If the digging time for the node behind it is instant, it is practically impossible to kill an entity and not accidentally dig the node behind it.
This adds a delay of
max(0.15, m_repeat_dig_time)after punching an entity to avoid this. Becausem_repeat_dig_timedefaults to0clamping it to a minimum value is necessary. I used0.15because that is the hardcoded digging delay between breaking nodes with instant digging time.How to test
repeat_dig_time