Fix include parser dropping sibling sub-includes under a shared intermediate relationship#127
Merged
lucacorti merged 1 commit intolucacorti:mainfrom Mar 20, 2026
Merged
Conversation
Owner
|
This is great, thank you! |
lucacorti
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two or more include paths share the same intermediate relationship node (e.g.
bestComments.user.companyandbestComments.user.topPosts), the parser processes each path separately and accumulates results one by one withKeyword.merge/2. Because both paths produce the same top-level key (best_comments: [user: [...]]), the second merge silently overwrites the first, dropping earlier sub-preloads from the Ecto preload list.The fix replaces the shallow
Keyword.merge/2with a recursivedeep_merge/2that combines nested keyword lists instead of overwriting them, so every leaf preload is retained regardless of ordering or nesting depth.Added four tests to
parse_include/2covering: