Merged
Conversation
- macOS: Use SecureTransport (via Security framework) - Windows: Use WinSSL/Schannel (via crypt32) - Remove OpenSSL requirement for faster compilation - Smaller binaries and better OS security integration
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| elseif(WIN32) | ||
| set(HTTPLIB_USE_WINSSL ON CACHE BOOL "Use WinSSL on Windows" FORCE) | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
Bug: SSL Configuration Breaks Linux HTTPS Support
The SSL configuration changes introduce two issues. When LLMCPP_USE_OPENSSL is enabled and OpenSSL is found, the required OpenSSL libraries (OpenSSL::SSL, OpenSSL::Crypto) are not linked, causing linker errors. Additionally, on Linux, if LLMCPP_USE_OPENSSL is OFF, httplib lacks an SSL backend since the native SSL fallback only supports macOS and Windows, breaking HTTPS functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Makes OpenSSL optional with
LLMCPP_USE_OPENSSL; defaults to native SSL (SecureTransport/WinSSL) and updates httplib flags and link settings accordingly.LLMCPP_USE_OPENSSLoption; prefer native SSL by default with status messages and fallback if OpenSSL not found.find_package(OpenSSL)to optional (QUIET) and conditional use.httplibconfig: conditionally setHTTPLIB_USE_OPENSSL,HTTPLIB_USE_SECURE_TRANSPORT,HTTPLIB_USE_WINSSL; keepHTTPLIB_USE_ZLIBandHTTPLIB_USE_BROTLIoff.OpenSSL::SSLandOpenSSL::Crypto; rely on platform SSL (CoreFoundation/Security on macOS, WinSSL on Windows) andhttplib::httplib.Written by Cursor Bugbot for commit ecf67ed. This will update automatically on new commits. Configure here.