Skip to content

remove usage of socket.SocketType.#66

Merged
lucas-six merged 2 commits intomainfrom
develop
Jul 25, 2022
Merged

remove usage of socket.SocketType.#66
lucas-six merged 2 commits intomainfrom
develop

Conversation

@lucas-six
Copy link
Copy Markdown
Owner

@lucas-six lucas-six commented Jul 25, 2022

See agronholm/anyio#302 (comment):

SocketType is an alias for the private _socket.socket class, a superclass of socket.socket.
It is better to just always use socket.socket in types.

See https://bugs.python.org/issue44261 and python/typeshed#5545 for some context.

@lucas-six lucas-six added the bug Something isn't working label Jul 25, 2022
@lucas-six lucas-six added this to the v0.0.1-beta milestone Jul 25, 2022
@lucas-six lucas-six self-assigned this Jul 25, 2022
@lucas-six lucas-six merged commit 1852ebd into main Jul 25, 2022
lucas-six added a commit to lucas-six/python-handbook that referenced this pull request Jul 25, 2022
@lucas-six
remove usage of socket.SocketType.
715d7ca 
See lucas-six/python-cookbook#66.
@lucas-six lucas-six mentioned this pull request Jul 25, 2022
Merged
lucas-six added a commit to lucas-six/python-handbook that referenced this pull request Jul 25, 2022
@lucas-six
remove usage of socket.SocketType. (#96)
3609140 
See lucas-six/python-cookbook#66.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lucas-six lucas-six

Labels

bug Something isn't working

Projects

None yet

Milestone

v0.0.1-beta

Development

Successfully merging this pull request may close these issues.

1 participant

@lucas-six