fix: register OAuth handler and guard activation awaits#12
Merged
MarcelRoozekrans merged 2 commits intomainfrom Mar 22, 2026
Merged
fix: register OAuth handler and guard activation awaits#12MarcelRoozekrans merged 2 commits intomainfrom
MarcelRoozekrans merged 2 commits intomainfrom
Conversation
The OAuth flow opens OpenRouter in the browser, but after authorizing, the vscode://lucent-code/oauth-callback redirect had no handler registered. Added registerUriHandler so the callback is received and the API key is exchanged and stored automatically. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
loadSkills(), connectMcpServers(), and instructionsLoader.load() were unguarded awaits in activate(). If any threw (e.g. network error, bad MCP config, missing file), the entire extension would fail to activate and the webview panel would be blank. All three now have .catch() handlers that log a warning and continue, so the core chat functionality always comes up. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lucent-code | 60dce9c | Commit Preview URL Branch Preview URL |
Mar 22 2026, 06:38 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vscode://lucent-code/oauth-callbackredirect had no handler, so "Open App" on OpenRouter did nothingactivate()awaits —loadSkills(),connectMcpServers(), andinstructionsLoader.load()were unguarded; any network error or bad config would crash activation and show a blank panelTest plan
🤖 Generated with Claude Code