Fix gen deps #68
Merged
Fix gen deps #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also get the main workspace and test workspace at the same version of rules_java
We're on an old version of protobuf, which uses an old version of rules_jvm_external. Because the protobuf dependency came before rules_jvm_external in the WORKSPACE file we were ending up with the wrong version. A similar problem exists with stardoc, so it was also moved.
jadenPete
approved these changes
Nov 13, 2024
| # rules_cc | ||
|
|
||
| http_archive( | ||
| name = "rules_cc", |
Author
There was a problem hiding this comment.
It's a dependency of one of our dependencies. Without specifying a more up to date version, something in one of our dependencies' starlark functions breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were accidentally using an old version of rules_jvm_external. The return of stardoc exposed this.