Skip to content

Add option to use bytebin for exports/imports#2432

Merged
lucko merged 1 commit into
LuckPerms:masterfrom
Turbotailz:feature/export-upload
Jul 4, 2020
Merged

Add option to use bytebin for exports/imports#2432
lucko merged 1 commit into
LuckPerms:masterfrom
Turbotailz:feature/export-upload

Conversation

@Turbotailz
Copy link
Copy Markdown
Member

Allows users to export to bytebin instead of saving to file.

  • /lp export --upload - returns the 10 digit bytebin code
  • /lp import <code> --upload

image

A couple things to note:

  • It does not perform any checks on the import to see if the JSON is formed correctly, I'm not sure if this is handled by the Importer class already.
  • There is no way to copy the code, which may be annoying to some users. I considered letting users click a link for the bytebin upload but IMO it seems unnecessary.

Let me know if there is anything that should be changed. I'm not very comfortable using Java so there will likely be things that can be done better :P

@lucko
Copy link
Copy Markdown
Member

lucko commented Jul 4, 2020

Looks good to me, thanks!

@lucko lucko merged commit 0fd7f64 into LuckPerms:master Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants