Skip to content

SpongeAPI 8#2728

Merged
lucko merged 4 commits into
masterfrom
sponge8
Feb 7, 2022
Merged

SpongeAPI 8#2728
lucko merged 4 commits into
masterfrom
sponge8

Conversation

@lucko
Copy link
Copy Markdown
Member

@lucko lucko commented Nov 17, 2020

No description provided.

@lucko
Copy link
Copy Markdown
Member Author

lucko commented Nov 22, 2020

Test jar LuckPerms-Sponge-5.2.43.jar compiled from this branch: https://we.tl/t-8AYRD2N0kp

@dualspiral
Copy link
Copy Markdown

One thing, when you update someone's permissions, you will want to call Sponge.getCommandManager().updateCommandTreeForPlayer(ServerPlayer); for any player that has had their permissions updated so Sponge will send the updated command tree to the player.

@lucko
Copy link
Copy Markdown
Member Author

lucko commented Nov 28, 2020

Sure will do - do you know if it's safe to call that async?

@Zidane
Copy link
Copy Markdown

Zidane commented Dec 1, 2020

@dualspiral @lucko That would not be safe to call async.

@lucko
Copy link
Copy Markdown
Member Author

lucko commented Dec 1, 2020

Thanks 👍

Added that, here's another jar: https://we.tl/t-7EKaJk4gGE

@funniray
Copy link
Copy Markdown
Contributor

Sponge's API 8 seems to have changed all calls such as getPlayer() to just player() and it appears that this branch no longer works.

Are there any plans currently to update this branch to the latest version of API 8?

@lucko
Copy link
Copy Markdown
Member Author

lucko commented May 26, 2021

I'm waiting until SpongeAPI 8 satablises before rebasing and updating this.

@lucko
Copy link
Copy Markdown
Member Author

lucko commented Sep 24, 2021

Updated to latest Sponge API.. new test build:

LuckPerms-Sponge-5.3.78.jar.zip

@lucko lucko mentioned this pull request Sep 24, 2021
@lucko
Copy link
Copy Markdown
Member Author

lucko commented Sep 24, 2021

LuckPerms-Sponge-5.3.80.jar.zip

@lucko lucko added the type: new platform The issue is suggesting the implementation of a new platform / platform version. label Oct 10, 2021
@Lunoro
Copy link
Copy Markdown

Lunoro commented Oct 17, 2021

There's an error with a scheduler in 5.3.80. (latest API changes)

@johnfriedrich
Copy link
Copy Markdown

https://pastebin.com/CSK6cNYN error on load

@dualspiral
Copy link
Copy Markdown

Just as a note, I notice that stack trace is on SpongeForge which is somewhat behind SpongeVanilla in implementation, particularly during loading. I would suggest testing against SpongeVanilla - if it works there, it more likely needs sorting in SF, not LP.

@lucko
Copy link
Copy Markdown
Member Author

lucko commented Oct 17, 2021

@tyhdefu
Copy link
Copy Markdown

tyhdefu commented Jan 22, 2022

Sponge 8 has stablised version 8.0.0 of the API - https://forums.spongepowered.org/t/status-update-8th-january-2022-spongeapi-8-released/39861 (Although no stable release of the implementation yet)
So this should be changed to be using the non-snapshot version of the api and fixed for any changes.
Thanks for all your work on LuckPerms.

@lucko lucko merged commit ee79f53 into master Feb 7, 2022
@lucko lucko deleted the sponge8 branch June 14, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: new platform The issue is suggesting the implementation of a new platform / platform version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants