Fabric - Compatibility with 1.17#3053
Conversation
This change makes it compatible with both 1.16 and 1.17
45c40e8 to
853b702
Compare
|
In the meantime, you should also update all these dependencies ;) https://github.com/lucko/LuckPerms/blob/master/fabric/build.gradle#L15 |
|
Temporary build with this PR applied: |
That needs to be done eventually, but changing the There were little changes between Minecraft 1.17-rc1 and 1.17, and I can confirm LuckPerms still works with 1.17 with this PR applied. |
|
Right, but I'm unsure remapped methods still work on 1.17. |
|
Thank you! |
When testing with Fabric for 1.17-rc1, this exception occurred when a player joins:
This is because the enum value
GameMode.NOT_SETwas removed in 1.17.The GameMode class now contains a new method to check for the id
-1(see snippet below), but using that would break compatibility with 1.16. That's why I decided to hard code the-1ID.I build LuckPerms from source with this patch applied, and confirmed that it works fine with 1.17-rc1 then.