Skip to content

Updated Java/Gradle and FabricMC components#3121

Closed
DrakoTrogdor wants to merge 1 commit into
LuckPerms:masterfrom
DrakoTrogdor:master
Closed

Updated Java/Gradle and FabricMC components#3121
DrakoTrogdor wants to merge 1 commit into
LuckPerms:masterfrom
DrakoTrogdor:master

Conversation

@DrakoTrogdor
Copy link
Copy Markdown

@DrakoTrogdor DrakoTrogdor commented Jul 29, 2021

Mostly just minor tweaks in order to compile it in my environment.
Updated:
Java 16
Gradle 7.1.1
Minecraft 1.17.1 (fabric server)
FabricMC API 0.37.0+1.17
yarn 1.17.1+build.14
Fabric-loader 0.11.6

@emilyy-dev
Copy link
Copy Markdown
Member

emilyy-dev commented Jul 29, 2021

I don't think that updating the whole plugin to Java 16 can be considered a "minor tweak", I don't have any stats in hand but I think it's safe to assume that many servers that use LuckPerms don't run on Java 16.

@underscore11code
Copy link
Copy Markdown
Member

Looking at the global bStats statistics for Bukkit, only ~46% of servers are running J16. We can assume that LP probably has a similar percentage.

@emilyy-dev
Copy link
Copy Markdown
Member

And that is Bukkit only, there aren't any precise statistics over the other platforms LP runs on (bStats Sponge being opt-in doesn't really contribute to any safe assumptions)

@lucko
Copy link
Copy Markdown
Member

lucko commented Aug 20, 2021

Implemented in ba52259 & 93683c3 - although I have opted to keep the other platforms on Java 8 for now.

Thank you for the PR :)

@lucko lucko closed this Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants