Group rename - Save renamed group before syncing with storage#3129
Merged
Conversation
Had the catastrophically undesired side effect of refreshing the new/renamed group from storage, discarding **every** permission that was added after the group creation Signed-off-by: emilyy-dev <35617540+emilyy-dev@users.noreply.github.com>
Member
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the newly introduced
--update-parent-listsflag in the group rename command, it had the catastrophically undesired side effect of refreshing the new/renamed group from storage, discarding every permission that was added after the group creation.The primary change is really in GroupRename, but to ensure that the bulk operation + syncing happens after the group is saved, I ended up adapting the StorageAdapter to return the messaging service request's future for continuation purposes.